-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dbp 1066 helm charts improvements #776
Open
M-Schiborr
wants to merge
14
commits into
main
Choose a base branch
from
DBP-1066-helm-charts-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aimee-889
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but i would only merge this together with a PR in spsh-app-release, since as long as these are not merged together, a new rollout to infra staging and prod would not run through
* Marking relevant places with todo comments * Fix tests * Fixed issue where an ox user can't have different address books * Renamed event * Publish the event only once * Fix email re-activation * Tests for the new handler * Avoiding early returns * Remove todo comments --------- Co-authored-by: Marvin Rode <[email protected]>
…il is disabled, new Event EmailAddressDisabledEvent and unit tests. (#793)
* add indexes+extension * add extension to test-container * add extension to db-init
* Changes to config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide Configs as helm values and not as 1P Secrets. In combination with https://github.com/dBildungsplattform/spsh-app-release/pull/34
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review